GH-38452: [C++][Benchmark] Adding benchmark for LZ4/Snappy Compression#38453
Conversation
|
|
|
I get the following error with this PR: |
|
This is my fault, I just add the code without checking. I've re-check the logic here. The LZ4 and Snappy doesn't support Streaming ( probabily this is the reason origin tests doesn't add them). Now I've remove the streaming for these two Codec. |
|
For the record, benchmark numbers here: |
It seems that streaming (de)compression is generally slower than the non-streaming parity. |
|
There may be some memory allocation costs for streaming (de)compression, while non-streaming is stateless. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 73589dd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ression (apache#38453) ### Rationale for this change This patch add LZ4 (LZ4_RAW in Parquet standard) and Snappy compression/decompression benchmark. ### What changes are included in this PR? Add groups of benchmarks. ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: apache#38452 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…ression (apache#38453) ### Rationale for this change This patch add LZ4 (LZ4_RAW in Parquet standard) and Snappy compression/decompression benchmark. ### What changes are included in this PR? Add groups of benchmarks. ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: apache#38452 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
This patch add LZ4 (LZ4_RAW in Parquet standard) and Snappy compression/decompression benchmark.
What changes are included in this PR?
Add groups of benchmarks.
Are these changes tested?
no
Are there any user-facing changes?
no