Skip to content

ARROW-4831: [C++] CMAKE_AR is not passed to ZSTD thirdparty dependency #3885

Closed
kszucs wants to merge 1 commit into
apache:masterfrom
kszucs:ARROW-4831
Closed

ARROW-4831: [C++] CMAKE_AR is not passed to ZSTD thirdparty dependency #3885
kszucs wants to merge 1 commit into
apache:masterfrom
kszucs:ARROW-4831

Conversation

@kszucs

@kszucs kszucs commented Mar 13, 2019

Copy link
Copy Markdown
Member

Test it via docker.

  1. Start an interactive shell in the conda container:
docker run -it --rm -v /local/path/to/arrow:/arrow ursalab/amd64-ubuntu-18.04-conda-python-3.6:worker bash
  1. Execute the following build from /arrow withing the container:
export ARROW_BUILD_TYPE=debug
export ARROW_BUILD_TOOLCHAIN=$CONDA_PREFIX
export ARROW_HOME=$CONDA_PREFIX
export PARQUET_HOME=$CONDA_PREFIX
export PYARROW_CMAKE_GENERATOR=Ninja

mkdir -p cpp/build
pushd cpp/build

cmake -GNinja \
      -DCMAKE_BUILD_TYPE=$ARROW_BUILD_TYPE \
      -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
      -DARROW_PYTHON=ON \
      -DCMAKE_AR=${AR} \
      -DCMAKE_RANLIB=${RANLIB} \
      ..
ninja
ninja install

popd

pushd python

python setup.py build_ext --inplace --build-type=$ARROW_BUILD_TYPE
py.test -sv pyarrow

popd

@kszucs

kszucs commented Mar 13, 2019

Copy link
Copy Markdown
Member Author

@wesm please review, I'd need it to fix the conda buildbot builds voltrondata-labs/ursabot#13

@xhochy xhochy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wesm wesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I guess this might cause a rebase artifact

@wesm wesm closed this in 0c4f857 Mar 13, 2019
@xhochy

xhochy commented Mar 14, 2019

Copy link
Copy Markdown
Member

@xhochy

xhochy commented Mar 14, 2019

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants