Skip to content

MINOR: [Docs] local_timestamp kernel docs are not linked in python docs#39274

Merged
jorisvandenbossche merged 1 commit into
apache:mainfrom
rok:minor_local_timestamp
Dec 20, 2023
Merged

MINOR: [Docs] local_timestamp kernel docs are not linked in python docs#39274
jorisvandenbossche merged 1 commit into
apache:mainfrom
rok:minor_local_timestamp

Conversation

@rok

@rok rok commented Dec 18, 2023

Copy link
Copy Markdown
Member

Rationale for this change

local_timestamp kernel docs are linked in cpp but not in python docs.

What changes are included in this PR?

This adds a rst link in python docs

Are these changes tested?

No

Are there any user-facing changes?

Change will be visible in the docs

@rok

rok commented Dec 18, 2023

Copy link
Copy Markdown
Member Author

It seems I missed adding the link in the original PR #34208.

@rok

rok commented Dec 18, 2023

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions

Copy link
Copy Markdown

Revision: bba16c9

Submitted crossbow builds: ursacomputing/crossbow @ actions-2bdeb8491e

Task Status
preview-docs GitHub Actions

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit b1fcba1 into apache:main Dec 20, 2023
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Dec 20, 2023
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Dec 20, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b1fcba1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…cs (apache#39274)

### Rationale for this change

local_timestamp kernel docs are linked in [cpp](https://arrow.apache.org/docs/cpp/compute.html#timezone-handling) but not in [python docs](https://arrow.apache.org/docs/python/api/compute.html#timezone-handling).

### What changes are included in this PR?

This adds a rst link in python docs

### Are these changes tested?

No

### Are there any user-facing changes?

Change will be visible in the docs

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants