Skip to content

GH-40649: [CI][Release][Java] Use Maven 3.8 for verify-rc-source-java-linux-almalinux-8-amd64#40650

Closed
kou wants to merge 2 commits into
apache:mainfrom
kou:release-java
Closed

GH-40649: [CI][Release][Java] Use Maven 3.8 for verify-rc-source-java-linux-almalinux-8-amd64#40650
kou wants to merge 2 commits into
apache:mainfrom
kou:release-java

Conversation

@kou

@kou kou commented Mar 18, 2024

Copy link
Copy Markdown
Member

Rationale for this change

#39696 requires Maven 3.6 or later.

What changes are included in this PR?

Use Maven 3.8.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners March 18, 2024 21:37
@kou

kou commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-java-linux-almalinux-8-amd64

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #40649 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Mar 18, 2024
@github-actions

This comment was marked as outdated.

@vibhatha

Copy link
Copy Markdown
Contributor
=============================
Build and test Java libraries
=============================
/arrow/java /arrow /
/arrow/dev/release/verify-release-candidate.sh: line 614: mvn: command not found
Failed to verify release candidate. See /tmp/arrow-HEAD.FB64e for details.

@kou

kou commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-java-linux-almalinux-8-amd64

@github-actions

Copy link
Copy Markdown

Revision: 3cbf8c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-92e7ff8fc8

Task Status
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions

@vibhatha

Copy link
Copy Markdown
Contributor

@kou

kou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

Should we re-run?

Done!

@vibhatha

Copy link
Copy Markdown
Contributor

@github-actions crossbow submit java

@github-actions

Copy link
Copy Markdown

Revision: 3cbf8c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c4db745cb

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@vibhatha

Copy link
Copy Markdown
Contributor

@github-actions crossbow submit verify-rc-source-java-linux-almalinux-8-amd64

@github-actions

Copy link
Copy Markdown

Revision: 3cbf8c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-2f9781ecf4

Task Status
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions

@vibhatha

Copy link
Copy Markdown
Contributor

@kou I think something is missing here. I am not quite sure what. Need to evaluate further.

@kou

kou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

The error message:

https://github.com/ursacomputing/crossbow/actions/runs/8335526861/job/22811169947#step:6:52650

Error:  Error occurred during initialization of boot layer
Error:  java.lang.module.FindException: Module flatbuffers.java not found, required by org.apache.arrow.vector
Error:  Error occurred during initialization of boot layer
Error:  java.lang.module.FindException: Module flatbuffers.java not found, required by org.apache.arrow.vector

@kou

kou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

Is flatbuffers.java an auto generated file?

@kou

kou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

It's referred from

requires flatbuffers.java;

@kou

kou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

@jduo Do you know what is the problem of #40650 (comment) ? Should we use different Maven version? (Maven 3.8 has a problem?)

@vibhatha

Copy link
Copy Markdown
Contributor

@kou is there a way to locally test this using docker/archery to reproduce if possible?

@jduo

jduo commented Mar 19, 2024

Copy link
Copy Markdown
Member

It's referred from

requires flatbuffers.java;

flatbuffers.java is the automatically generated module name for flatbuffers-java.jar (rather than being an actual .java file).

@jduo

jduo commented Mar 19, 2024

Copy link
Copy Markdown
Member

@jduo Do you know what is the problem of #40650 (comment) ? Should we use different Maven version? (Maven 3.8 has a problem?)

When adding module support, I ran into issues with very specific versions of some plugins but don't remember the maven version itself being an issue. The ones that really caused problems were the maven-shade-plugin and the maven-analyze-plugin.

@kou

kou commented Mar 20, 2024

Copy link
Copy Markdown
Member Author

is there a way to locally test this using docker/archery to reproduce if possible?

You can use archery docker run -e TEST_DEFAULT=0 TEST_JAVA=1 almalinux-verify-rc.

@kou

kou commented Mar 20, 2024

Copy link
Copy Markdown
Member Author

@jduo Thanks for taking a look at this. Hmm... It seems that we need to look into this to fix this...

@kou

kou commented Mar 20, 2024

Copy link
Copy Markdown
Member Author

AlmaLinux 8 ships Maven 3.8.5.
#40514 used Maven 3.8.7 via conda and it worked.

It seems that Maven 3.8.5 doesn't work.

I close this in favor of #40514. #40514 also uses newer Maven.

@kou kou closed this Mar 20, 2024
@kou kou deleted the release-java branch March 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants