ARROW-5284: [Rust] Replace libc with std::alloc for memory allocation#4273
Closed
sunchao wants to merge 6 commits into
Closed
ARROW-5284: [Rust] Replace libc with std::alloc for memory allocation#4273sunchao wants to merge 6 commits into
sunchao wants to merge 6 commits into
Conversation
andygrove
approved these changes
May 10, 2019
| @@ -18,80 +18,35 @@ | |||
| //! Defines memory-related functions, currently mostly to make this library play nicely | |||
| //! with C. | |||
Member
There was a problem hiding this comment.
is this comment still relevant?
Member
Author
There was a problem hiding this comment.
This doesn't seem related anymore. Will delete later.
Member
Author
|
Please do not commit this yet - I still need to investigate the windows test failure. |
Contributor
|
Hey @sunchao, I'm able to reproduce the failure, it comes from I ran cargo test with 1 thread to find the offender. |
Member
Author
|
Thanks @nevi-me . I think it fails because it was trying to dealloc a null pointer. Not sure why it doesn't fail on linux. |
Member
Author
No. I'm going to work on that next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.