Skip to content

MINOR: [C++] Make argument name consistent#44973

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:minor-n-ulps
Dec 9, 2024
Merged

MINOR: [C++] Make argument name consistent#44973
pitrou merged 1 commit into
apache:mainfrom
pitrou:minor-n-ulps

Conversation

@pitrou

@pitrou pitrou commented Dec 9, 2024

Copy link
Copy Markdown
Member

Followup to #44955

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

❌ GitHub issue #undefined could not be retrieved.

@pitrou pitrou requested a review from mapleFU December 9, 2024 11:51
@pitrou pitrou marked this pull request as ready for review December 9, 2024 11:51
@github-actions github-actions Bot added the awaiting review Awaiting review label Dec 9, 2024
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

❌ GitHub issue #undefined could not be retrieved.

1 similar comment
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

❌ GitHub issue #undefined could not be retrieved.

@pitrou

pitrou commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

@kou @raulcd The "Dev PR" failure is weird here, any idea?

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 9, 2024
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

❌ GitHub issue #undefined could not be retrieved.

@raulcd

raulcd commented Dec 9, 2024

Copy link
Copy Markdown
Member

The "Dev PR" failure is weird here, any idea?

I think I broke the check for PRs with MINOR when removing the JIRA code. We were checking whether it was a JIRA issue or a GitHub issue in the past (or doing nothing if it wasn't either). Now we assume is a GitHub issue:
https://github.com/apache/arrow/pull/44936/files#diff-cdf16bb28f8aef5eeb1213fa302a992b3c8f8eba0e2b7af893e794cb5cdbf0fcR80-R83

I'll open an issue to fix this.

@raulcd

raulcd commented Dec 9, 2024

Copy link
Copy Markdown
Member

I've opened: #44974

@pitrou pitrou merged commit e747af6 into apache:main Dec 9, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Dec 9, 2024
@pitrou pitrou deleted the minor-n-ulps branch December 9, 2024 13:45
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e747af6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 78 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants