Skip to content

GH-49552: [C++][FlightRPC][ODBC] Enable ODBC test build on Linux #49668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
May 21, 2026
Merged

GH-49552: [C++][FlightRPC][ODBC] Enable ODBC test build on Linux #49668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c88ee5
Enable ODBC test build on Linux
justing-bq Apr 6, 2026
682bab2
Address review feedback
justing-bq Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/scripts/cpp_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ if ! type minio >/dev/null 2>&1; then
fi
case "$(uname)" in
Linux)
exclude_tests+=("arrow-flight-sql-odbc-test")
Copy link
Copy Markdown
Member

@kou kou May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We remove this later, right?

Copy link
Copy Markdown
Contributor Author

@justing-bq justing-bq May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. This gets removed in 9e8272d.

Copy link
Copy Markdown
Member

@kou kou May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which PR does include the commit?
GH-49786?

Copy link
Copy Markdown
Contributor Author

@justing-bq justing-bq May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#49786 which will be undrafted as soon as this PR gets merged.

n_jobs=$(nproc)
;;
Comment thread
justing-bq marked this conversation as resolved.
Darwin)
Expand Down
5 changes: 1 addition & 4 deletions cpp/src/arrow/flight/sql/odbc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ endif()

add_subdirectory(odbc_impl)
if(ARROW_BUILD_TESTS)
if(WIN32 OR APPLE)
# GH-49552 TODO: Enable Linux test build
add_subdirectory(tests)
endif()
add_subdirectory(tests)
endif()

arrow_install_all_headers("arrow/flight/sql/odbc")
Expand Down
396 changes: 149 additions & 247 deletions cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading