Skip to content

ARROW-836: add test for pandas conversion of timedelta, currently unimplemented#551

Closed
jreback wants to merge 1 commit into
apache:masterfrom
jreback:timedelta
Closed

ARROW-836: add test for pandas conversion of timedelta, currently unimplemented#551
jreback wants to merge 1 commit into
apache:masterfrom
jreback:timedelta

Conversation

@jreback

@jreback jreback commented Apr 16, 2017

Copy link
Copy Markdown
Contributor

@jreback

jreback commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

so looks like this type should be added. The impl should be almost exactly like TimestampType (but no need for timezones). and the units would be exactly the same as supported by Timestamps.

@wesm

wesm commented Apr 16, 2017

Copy link
Copy Markdown
Member

Agreed -- we have a SQL-compliant "interval" type (https://github.com/apache/arrow/blob/master/format/Schema.fbs#L143), but no absolute timedelta. The implementation would be the same as Time (https://github.com/apache/arrow/blob/master/format/Schema.fbs#L106), though perhaps we can relax the storage constraint and use 64 bits for everything.

Would you mind opening a JIRA and prefixing the PR title with ARROW-XXX:? thanks @jreback !

@jreback

jreback commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

yes I think the current definition of IntervalType is not going to work here; that looks for year/months.

@jreback

jreback commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

@wesm

wesm commented Apr 16, 2017

Copy link
Copy Markdown
Member

Cool, as a bookkeeping matter can you also make a JIRA for this patch and update the PR title? https://github.com/apache/arrow#how-to-contribute

@jreback jreback changed the title TST: add test for pandas conversion of timedelta, currently unimplemented ARROW-836: add test for pandas conversion of timedelta, currently unimplemented Apr 16, 2017
@jreback

jreback commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

@wesm wesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 09e6ead Apr 16, 2017
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
…mplemented

xref pandas-dev/pandas#16004

Author: Jeff Reback <jeff.reback@twosigma.com>

Closes apache#551 from jreback/timedelta and squashes the following commits:

cfd310e [Jeff Reback] TST: add test for pandas conversion of timedelta, currently unimplemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants