ARROW-8112: [FlightRPC][C++] make sure status codes round-trip through gRPC#6615
Closed
lidavidm wants to merge 3 commits into
Closed
ARROW-8112: [FlightRPC][C++] make sure status codes round-trip through gRPC#6615lidavidm wants to merge 3 commits into
lidavidm wants to merge 3 commits into
Conversation
Member
Author
|
Python is failing and would be fixed by #6614 |
Member
Author
|
@pitrou I implemented the headers idea you suggested. |
lidavidm
commented
Mar 13, 2020
Member
Author
There was a problem hiding this comment.
Is this worth refactoring out into status.h?
Member
Author
There was a problem hiding this comment.
(this being the int<->statuscode mapping)
Member
There was a problem hiding this comment.
Hmm... perhaps as a helper function?
Member
Author
There was a problem hiding this comment.
I've made a helper function, but kept it internal, since there doesn't seem to be a need to serialize statuses outside of Flight.
lidavidm
force-pushed
the
flight-missing-codes
branch
from
2dd7c89 to
d86276c
Compare
Member
Author
|
This is segfaulting in Python tests, taking a look... |
lidavidm
force-pushed
the
flight-missing-codes
branch
2 times, most recently
from
f3fe0db to
2b643fd
Compare
pitrou
requested changes
Mar 16, 2020
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
Thank you! This will be a useful improvement.
Member
There was a problem hiding this comment.
Hmm... perhaps as a helper function?
lidavidm
force-pushed
the
flight-missing-codes
branch
from
2b643fd to
2af6537
Compare
pitrou
force-pushed
the
flight-missing-codes
branch
from
2af6537 to
da2b346
Compare
Member
|
Thank you @lidavidm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still unmapped status codes, but these are the ones that correspond closely to a gRPC one. (OutOfMemory, for instance, doesn't quite line up with RESOURCE_EXHAUSTED since the latter is intended for some application-level resource like a disk quota, not an internal server error.)