Skip to content

ARROW-4815: [Rust] [DataFusion] Add support for SQL wilcard operator#6716

Closed
andygrove wants to merge 2 commits into
apache:masterfrom
andygrove:ARROW-4815
Closed

ARROW-4815: [Rust] [DataFusion] Add support for SQL wilcard operator#6716
andygrove wants to merge 2 commits into
apache:masterfrom
andygrove:ARROW-4815

Conversation

@andygrove

Copy link
Copy Markdown
Member

No description provided.

@andygrove andygrove requested review from nevi-me and paddyhoran March 25, 2020 14:31
@github-actions

Copy link
Copy Markdown

@andygrove

Copy link
Copy Markdown
Member Author

@sinistersnare FYI

@andygrove

Copy link
Copy Markdown
Member Author

@paddyhoran @nevi-me Any objection to me merging this one?

@paddyhoran paddyhoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove closed this in 76c6424 Mar 26, 2020
@kou

kou commented Mar 26, 2020

Copy link
Copy Markdown
Member

@andygrove This commit on master failed Rust lint: https://github.com/apache/arrow/runs/537449095

2020-03-26T19:06:49.5792511Z Diff in /arrow/rust/datafusion/src/sql/planner.rs at line 272:
2020-03-26T19:06:49.5793877Z                  Ok(Expr::Literal(ScalarValue::Utf8(s.clone())))
2020-03-26T19:06:49.5794168Z              }
2020-03-26T19:06:49.5794309Z  
2020-03-26T19:06:49.5795629Z -            ASTNode::SQLAliasedExpr(ref expr, ref alias) => {
2020-03-26T19:06:49.5796217Z -                Ok(Alias(Arc::new(self.sql_to_rex(&expr, schema)?), alias.to_owned()))
2020-03-26T19:06:49.5796537Z -            }
2020-03-26T19:06:49.5796703Z +            ASTNode::SQLAliasedExpr(ref expr, ref alias) => Ok(Alias(
2020-03-26T19:06:49.5796913Z +                Arc::new(self.sql_to_rex(&expr, schema)?),
2020-03-26T19:06:49.5797166Z +                alias.to_owned(),
2020-03-26T19:06:49.5797325Z +            )),
2020-03-26T19:06:49.5797459Z  
2020-03-26T19:06:49.5797599Z              ASTNode::SQLIdentifier(ref id) => {
2020-03-26T19:06:49.5797792Z                  match schema.fields().iter().position(|c| c.name().eq(id))

Could you check this?

@paddyhoran

Copy link
Copy Markdown
Contributor

A fix will be included in #6724

@kou

kou commented Mar 26, 2020

Copy link
Copy Markdown
Member

OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants