Skip to content

ARROW-8246: [C++] Add -Wa,-mbig-obj to CXXFLAGS on MinGW if it is supported#6743

Closed
wesm wants to merge 2 commits into
apache:masterfrom
wesm:ARROW-8246
Closed

ARROW-8246: [C++] Add -Wa,-mbig-obj to CXXFLAGS on MinGW if it is supported#6743
wesm wants to merge 2 commits into
apache:masterfrom
wesm:ARROW-8246

Conversation

@wesm

@wesm wesm commented Mar 27, 2020

Copy link
Copy Markdown
Member

Hopefully this will resolve issues with debug builds on MinGW

@wesm

wesm commented Mar 27, 2020

Copy link
Copy Markdown
Member Author

cc @kou @nealrichardson

@github-actions

Copy link
Copy Markdown

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou

kou commented Mar 27, 2020

Copy link
Copy Markdown
Member

@kou

kou commented Mar 27, 2020

Copy link
Copy Markdown
Member

Should we try debug build in this pull request?

@kou

kou commented Mar 27, 2020

Copy link
Copy Markdown
Member

I tried debug build on local but ld still takes a long time...

@kou

kou commented Mar 27, 2020

Copy link
Copy Markdown
Member

Oh, ld finished.
It seems that this fixes debug build problem on MinGW.

@wesm

wesm commented Mar 27, 2020

Copy link
Copy Markdown
Member Author

Ah great, thanks @kou for checking. Merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants