ARROW-7801: [Developer] Add issue_comment workflow to fix lint/style/codegen#6932
Closed
nealrichardson wants to merge 10 commits into
Closed
ARROW-7801: [Developer] Add issue_comment workflow to fix lint/style/codegen#6932nealrichardson wants to merge 10 commits into
nealrichardson wants to merge 10 commits into
Conversation
Member
|
Having this as a developer opt-in sounds good to me. |
nealrichardson
force-pushed
the
autotune2
branch
from
4987f4c to
3dfa64c
Compare
bkietz
requested changes
Apr 16, 2020
bkietz
left a comment
bkietz
left a comment
Member
There was a problem hiding this comment.
I'm looking forward to trying this out!
Looks like CMAKE_FORMAT is disabled, though
Comment on lines
+86
to
+87
| if: false | ||
| # if: env.CMAKE_FORMAT == 'true' || endsWith(github.event.comment.body, 'everything') |
Member
Author
There was a problem hiding this comment.
Per the description:
- cmake_format is currently disabled because I didn't feel like fighting further with python versions and environments; in https://github.com/nealrichardson/arrow/runs/590355718?check_suite_focus=true#step:5:34 you can see that it pip installs cmake_format but then in the next line can't find cmake_format 🤷
Member
There was a problem hiding this comment.
Oops, sorry I missed that. Could you add a follow up JIRA and a matching todo comment?
| git config user.name "$(git log -1 --pretty=format:%an)" | ||
| git config user.email "$(git log -1 --pretty=format:%ae)" | ||
| git commit -a -m 'Autoformat/render all the things [automated commit]' || echo "No changes to commit" | ||
| - uses: r-lib/actions/pr-push@master |
Contributor
There was a problem hiding this comment.
There's no action from the base library that does this?
Member
Author
There was a problem hiding this comment.
Not afaik, not yet.
fsaintjacques
approved these changes
Apr 16, 2020
Contributor
|
autotune, are you ready? |
Contributor
|
@nealrichardson shouldn't my previous comment trigger something? |
Member
Author
|
@fsaintjacques no, it won't, not until this is merged. The PR description says:
|
nealrichardson
changed the title
kszucs
pushed a commit
that referenced
this pull request
Apr 20, 2020
…codegen #6411 tried to do this work automatically, but some were uncomfortable with that; this version instead is triggered by PR comment. Currently implemented: * R documentation (`roxygen2`, updating `r/man/*.Rd` based on docstrings in `r/R/*.R`) * clang-format on changes to `cpp/src` or `r/src` * cmake_format is currently disabled because I didn't feel like fighting further with python versions and environments; in https://github.com/nealrichardson/arrow/runs/590355718?check_suite_focus=true#step:5:34 you can see that it pip installs cmake_format but then in the next line can't find cmake_format 🤷 To trigger the build, add a comment with the message "autotune" (seemed appropriate since this is using computers to make sure our code stays in harmony). By default it will check for which files changed and only run the relevant tasks, but if you comment "autotune everything" it will run everything. Since `issue_comment` workflows are only run off the master branch, I tested this by merging these commits to master on my fork and triggering it on a PR there. See e.g. nealrichardson#2 (comment) Closes #6932 from nealrichardson/autotune2 Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6411 tried to do this work automatically, but some were uncomfortable with that; this version instead is triggered by PR comment.
Currently implemented:
roxygen2, updatingr/man/*.Rdbased on docstrings inr/R/*.R)cpp/srcorr/srcTo trigger the build, add a comment with the message "autotune" (seemed appropriate since this is using computers to make sure our code stays in harmony). By default it will check for which files changed and only run the relevant tasks, but if you comment "autotune everything" it will run everything.
Since
issue_commentworkflows are only run off the master branch, I tested this by merging these commits to master on my fork and triggering it on a PR there. See e.g. nealrichardson#2 (comment)