Skip to content

ARROW-8422: [Rust] [Parquet] Arrow to Parquet schema conversion#7090

Closed
nevi-me wants to merge 6 commits into
apache:masterfrom
nevi-me:ARROW-8422
Closed

ARROW-8422: [Rust] [Parquet] Arrow to Parquet schema conversion#7090
nevi-me wants to merge 6 commits into
apache:masterfrom
nevi-me:ARROW-8422

Conversation

@nevi-me

@nevi-me nevi-me commented May 3, 2020

Copy link
Copy Markdown
Contributor

Converts an Arrow schema to Parquet schema

@github-actions

github-actions Bot commented May 3, 2020

Copy link
Copy Markdown

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddyhoran paddyhoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor nit

Comment thread rust/parquet/src/arrow/schema.rs Outdated
.map(|fields| Schema::new_with_metadata(fields, metadata))
}

/// Convert arrow schema to parquet chema

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants