Skip to content

Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"#7802

Merged
kszucs merged 1 commit into
apache:masterfrom
wesm:revert-f86c4dbbc
Jul 20, 2020
Merged

Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"#7802
kszucs merged 1 commit into
apache:masterfrom
wesm:revert-f86c4dbbc

Conversation

@wesm

@wesm wesm commented Jul 19, 2020

Copy link
Copy Markdown
Member

This reverts commit f86c4db.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@emkornfield

Copy link
Copy Markdown
Contributor

I don't think we should revert this fully. This also fixes a bug with as_datetime flag. Per mailing list discussion let me see if I can get round trip this evening

@wesm

wesm commented Jul 20, 2020

Copy link
Copy Markdown
Member Author

OK. I won't be able to spend any time on it for several days at least

@emkornfield

Copy link
Copy Markdown
Contributor

I'll work on it tonight and try to get something out one way or another. Enjoy your time off

@kszucs kszucs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may revert this reversion, but merging to be able to cut 1.0.0-RC2.

@kszucs kszucs merged commit 23b19f6 into apache:master Jul 20, 2020
@BryanCutler

Copy link
Copy Markdown
Member

Let's just verify the Spark tests pass after the reverting.

@ursabot crossbow submit test-conda-python-3.8-spark-master

@BryanCutler

Copy link
Copy Markdown
Member

@ursabot crossbow submit test-conda-python-3.8-spark-master

@ursabot

ursabot commented Jul 20, 2020

Copy link
Copy Markdown

AMD64 Conda Crossbow Submit (#120385) builder failed.

Revision: 12840af

Clone Arrow: update (failure) step's stderr:

Cloning into '.'...
fatal: couldn't find remote ref refs/pull/7802/merge

@BryanCutler

Copy link
Copy Markdown
Member

@kszucs is there a way to kick off Spark integration tests right now on master?

@kszucs

kszucs commented Jul 20, 2020

Copy link
Copy Markdown
Member

@BryanCutler I already submitted them, the spark tests are still running https://github.com/ursa-labs/crossbow/branches/all?query=build-871

@kszucs

kszucs commented Jul 20, 2020

Copy link
Copy Markdown
Member

@BryanCutler seems like the spark tests are passing with the current master.

@BryanCutler

Copy link
Copy Markdown
Member

great, thanks @kszucs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants