ARROW-9147: [C++][Dataset] Support projection from null->any type#8343
Closed
bkietz wants to merge 4 commits into
Closed
ARROW-9147: [C++][Dataset] Support projection from null->any type#8343bkietz wants to merge 4 commits into
bkietz wants to merge 4 commits into
Conversation
pitrou
reviewed
Oct 5, 2020
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
Member
There was a problem hiding this comment.
Generally looks good to me, thanks! (the related tests are failing, though, on some builds)
pitrou
reviewed
Oct 6, 2020
bkietz
commented
Oct 6, 2020
Member
|
Remaining failures look unrelated? |
Member
|
Yes, they are. |
Member
|
Thanks @bkietz ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.