ARROW-6972: [C#] Support for StructArrays#8348
Closed
pgovind wants to merge 8 commits into
Closed
Conversation
pgovind
commented
Oct 5, 2020
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
pgovind
changed the title
eerhardt
reviewed
Oct 5, 2020
eerhardt
left a comment
eerhardt
left a comment
Contributor
There was a problem hiding this comment.
This is looking really good. Thanks for the quick turnaround on this.
kou
changed the title
- Fill out StructArray.Fields with correct data - NestedType.Children => Fields to match C++ naming - Add back StructType.GetFieldIndex and add tests - Minor code formatting
Contributor
|
@kou @nealrichardson - do you know why the assign-rust-labels job failed? |
Member
|
@eerhardt I haven't looked but I think the authors of that new workflow are working to fix it. You can ignore it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.apache.org/jira/browse/ARROW-6972
Add support for
StructArray. It'd be nice to have an easier way to construct aStructArray, but that can come in a follow up PR.cc @eerhardt @nealrichardson
Not sure who else works on the C# parts of the repo.