Skip to content

ARROW-10178: [CI] Remove patch to fix Spark master build#8352

Closed
BryanCutler wants to merge 3 commits into
apache:masterfrom
BryanCutler:ci-spark-integration-ARROW-10178
Closed

ARROW-10178: [CI] Remove patch to fix Spark master build#8352
BryanCutler wants to merge 3 commits into
apache:masterfrom
BryanCutler:ci-spark-integration-ARROW-10178

Conversation

@BryanCutler

Copy link
Copy Markdown
Member

Spark master branch has been updated for Arrow 1.0.1, the patch to fix Java compilation can be removed.

@BryanCutler

Copy link
Copy Markdown
Member Author

@ursabot crossbow submit test-conda-python-3.8-spark-master

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown

@ursabot

ursabot commented Oct 5, 2020

Copy link
Copy Markdown

AMD64 Conda Crossbow Submit (#131023) builder has been succeeded.

Revision: 7c62c5b

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-582

Task Status
test-conda-python-3.8-spark-master Github Actions

@BryanCutler

Copy link
Copy Markdown
Member Author

I think we might have to add a patch to fix that nested timezone problem from earlier in #7804 , but lets see how the integration run goes

@BryanCutler

BryanCutler commented Oct 6, 2020

Copy link
Copy Markdown
Member Author

Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is due to the changes in #7816

@BryanCutler

Copy link
Copy Markdown
Member Author

@ursabot crossbow submit test-conda-python-3.8-spark-master

@ursabot

ursabot commented Oct 6, 2020

Copy link
Copy Markdown

AMD64 Conda Crossbow Submit (#131422) builder has been succeeded.

Revision: ed31bb2

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-583

Task Status
test-conda-python-3.8-spark-master Github Actions

@BryanCutler

Copy link
Copy Markdown
Member Author

@kszucs the Spark integration tests are passing for master branch with this change, could you take a look? Thanks!

@emkornfield

Copy link
Copy Markdown
Contributor

Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is due to the changes in #7816

Was this patch necessary before? I thought we should be running Spark in a backwards compatibility mode that doesn't honor the TZ info. (maybe this got dropped from the patch?)

@BryanCutler

Copy link
Copy Markdown
Member Author

Oh, I didn't see there was a backwards compatible setting. I ran the tests locally and obviously failed without it. Let me remove the patch and run again here.

@BryanCutler

Copy link
Copy Markdown
Member Author

@ursabot crossbow submit test-conda-python-3.8-spark-master

@ursabot

ursabot commented Oct 7, 2020

Copy link
Copy Markdown

AMD64 Conda Crossbow Submit (#131560) builder has been succeeded.

Revision: 6a064e5

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-584

Task Status
test-conda-python-3.8-spark-master Github Actions

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kszucs

kszucs commented Oct 7, 2020

Copy link
Copy Markdown
Member

Thanks Bryan!

@BryanCutler BryanCutler deleted the ci-spark-integration-ARROW-10178 branch October 7, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants