ARROW-7960: [C++] Add support fo reading additional types#8376
Closed
emkornfield wants to merge 2 commits into
Closed
ARROW-7960: [C++] Add support fo reading additional types#8376emkornfield wants to merge 2 commits into
emkornfield wants to merge 2 commits into
Conversation
pitrou
changed the title
New types supported:
- Fixed Size list (will throw an incorrect error if nulls
are present, but this is best fixed after we recursively support
applying types).
- LargeList
- Maps
Still missing: LargeString and LargeBytes
Unimplemented functionality:
- Deduping maps on read.
Single column maps are converted to List of struct.
Other Fixed two bugs for FixedSizeLists:
1. Def levels genereated were incorrect (they only made sense for
two level lists).
2. Slices where not handled appropriately
Member
|
Rebased, fixed conflicts. |
pitrou
force-pushed
the
read_most_types
branch
from
42fa082 to
50c146a
Compare
pitrou
approved these changes
Oct 7, 2020
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
+1. Thank you very much @emkornfield .
Member
Member
|
CI failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New types supported:
Still missing: LargeString and LargeBytes
Unimplemented functionality:
Other:
Fixed two bugs for FixedSizeLists:
two level lists).