Skip to content

ARROW-10332: [Rust] Allow CSV reader to iterate from start up to end#8482

Closed
jorgecarleitao wants to merge 6 commits into
apache:masterfrom
jorgecarleitao:csv_many
Closed

ARROW-10332: [Rust] Allow CSV reader to iterate from start up to end#8482
jorgecarleitao wants to merge 6 commits into
apache:masterfrom
jorgecarleitao:csv_many

Conversation

@jorgecarleitao

Copy link
Copy Markdown
Member

This PR proposes the following changes:

  1. Make the CSV reader accept an optional argument to bound its iteration
  2. Simplify the next code via iterators
  3. Add a new struct to perform buffered iterations (useful to any reader)

@github-actions

Copy link
Copy Markdown

@jorgecarleitao jorgecarleitao marked this pull request as draft October 17, 2020 08:43
@jorgecarleitao jorgecarleitao marked this pull request as ready for review October 17, 2020 10:57

@nevi-me nevi-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and questions. i like the buffered iterator 👍

Comment thread rust/arrow/src/csv/reader.rs Outdated
Comment thread rust/arrow/src/csv/reader.rs Outdated
Comment thread rust/arrow/src/csv/reader.rs Outdated
Comment thread rust/arrow/src/util/buffered_iterator.rs Outdated

@nevi-me nevi-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants