Skip to content

ARROW-9963: [Python] Recognize datetime.timezone.utc as UTC on conversion python->pyarrow#8489

Closed
jorisvandenbossche wants to merge 2 commits into
apache:masterfrom
jorisvandenbossche:ARROW-9963
Closed

ARROW-9963: [Python] Recognize datetime.timezone.utc as UTC on conversion python->pyarrow#8489
jorisvandenbossche wants to merge 2 commits into
apache:masterfrom
jorisvandenbossche:ARROW-9963

Conversation

@jorisvandenbossche

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

@kszucs

kszucs commented Oct 19, 2020

Copy link
Copy Markdown
Member

@jorisvandenbossche python 3.5 build is failing.

@pitrou

pitrou commented Oct 19, 2020

Copy link
Copy Markdown
Member

Indeed, on Python 3.5, we have:

>>> timezone.utc.tzname(None)
'UTC+00:00'

@jorisvandenbossche jorisvandenbossche force-pushed the ARROW-9963 branch 2 times, most recently from af162f7 to 53aa00b Compare October 21, 2020 12:30
@jorisvandenbossche

Copy link
Copy Markdown
Member Author

I updated the expected return value for Python 3.5 to still be the former "+00:00" (instead of adding further special cases to the C++ code to "correct" this for python 3.5)

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants