ARROW-11504: [Rust] Added checks to List DataType (WIP IMPROVEMENTS)#9508
Closed
alamb wants to merge 3 commits into
Closed
ARROW-11504: [Rust] Added checks to List DataType (WIP IMPROVEMENTS)#9508alamb wants to merge 3 commits into
alamb wants to merge 3 commits into
Conversation
Contributor
Author
|
Plan is to rebase anything useful out of this PR into a new ticket -- we merged the original PR as is #9425 |
This was referenced Mar 13, 2021
Contributor
Author
alamb
added a commit
that referenced
this pull request
Mar 14, 2021
# Background: Left over cleanups suggested by from @sunchao on #9425 Broken out from #9508 # Rationale: This function is redundant with `OffsetSize::is_large` Closes #9690 from alamb/alamb/remove_prefix Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
that referenced
this pull request
Mar 15, 2021
…ead of `panic!` # Background: Left over cleanups suggested by from @sunchao on #9425 Broken out from #9508 # Rationale: Don't use panic! directly. However, since the caller of this function still calls `unwrap()`, I am not sure how much of an improvement this change really is. However it may set us up for a more `safe` future eventually Closes #9691 from alamb/alamb/fallable_list_conversion Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
# Background: Left over cleanups suggested by from @sunchao on apache/arrow#9425 Broken out from apache/arrow#9508 # Rationale: This function is redundant with `OffsetSize::is_large` Closes #9690 from alamb/alamb/remove_prefix Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
…ead of `panic!` # Background: Left over cleanups suggested by from @sunchao on apache/arrow#9425 Broken out from apache/arrow#9508 # Rationale: Don't use panic! directly. However, since the caller of this function still calls `unwrap()`, I am not sure how much of an improvement this change really is. However it may set us up for a more `safe` future eventually Closes #9691 from alamb/alamb/fallable_list_conversion Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based off of #9425 from @jorgecarleitao with some proposed resolutions to comments by @sunchao