Skip to content

ARROW-11707: [Rust] support CSV schema inference without file IO#9534

Closed
houqp wants to merge 3 commits into
apache:masterfrom
houqp:qp_csv
Closed

ARROW-11707: [Rust] support CSV schema inference without file IO#9534
houqp wants to merge 3 commits into
apache:masterfrom
houqp:qp_csv

Conversation

@houqp

@houqp houqp commented Feb 20, 2021

Copy link
Copy Markdown
Member

This patch set makes it possible for downstream application to do schema inference with IOs other than local filesystem.

Comment thread rust/arrow/src/csv/reader.rs Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a no op.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good catch.

@github-actions

Copy link
Copy Markdown

@codecov-io

codecov-io commented Feb 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #9534 (e3312f2) into master (35daca2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9534   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         245      245           
  Lines       56412    56414    +2     
=======================================
+ Hits        46442    46445    +3     
+ Misses       9970     9969    -1     
Impacted Files Coverage Δ
rust/arrow/src/csv/reader.rs 93.17% <100.00%> (+0.02%) ⬆️
rust/parquet/src/encodings/encoding.rs 95.05% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35daca2...e3312f2. Read the comment docs.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @houqp

Comment thread rust/arrow/src/csv/reader.rs Outdated
Comment thread rust/arrow/src/csv/reader.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good catch.

Comment thread rust/arrow/src/csv/reader.rs Outdated
@alamb

alamb commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

@houqp / @nevi-me is this PR ready to go? It looks good to me. I'll plan to merge it tomorrow if I don't hear anything otherwise

@nevi-me

nevi-me commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

@houqp / @nevi-me is this PR ready to go? It looks good to me. I'll plan to merge it tomorrow if I don't hear anything otherwise

I was going to wait for #9534 (comment)

@alamb

alamb commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

Makes sense @nevi-me -- sorry I was getting lost with the comment threads. Thank you

@houqp

houqp commented Feb 28, 2021

Copy link
Copy Markdown
Member Author

alright, pushed reader offset rewind fix.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.32%. Comparing base (35daca2) to head (e3312f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9534   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         245      245           
  Lines       56412    56414    +2     
=======================================
+ Hits        46442    46445    +3     
+ Misses       9970     9969    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants