ARROW-11756: [R] passing a partition as a schema leads to segfaults#9566
Closed
pachadotdev wants to merge 7 commits into
Closed
ARROW-11756: [R] passing a partition as a schema leads to segfaults#9566pachadotdev wants to merge 7 commits into
pachadotdev wants to merge 7 commits into
Conversation
jonkeane
reviewed
Feb 24, 2021
jonkeane
requested changes
Feb 24, 2021
jonkeane
left a comment
jonkeane
left a comment
Member
There was a problem hiding this comment.
Good work! A few suggestions for you to consider.
Contributor
Author
|
@jonkeane new PR changes in #fed2fd8, which passes verbose error message |
jonkeane
approved these changes
Feb 25, 2021
jonkeane
left a comment
jonkeane
left a comment
Member
There was a problem hiding this comment.
This looks good to me with a slightly edit to the actual message. Great work!
Contributor
Author
sure ! updated now |
nealrichardson
requested changes
Feb 25, 2021
nealrichardson
left a comment
nealrichardson
left a comment
Member
There was a problem hiding this comment.
Thanks! A few suggestions.
Contributor
Author
|
@nealrichardson @jonkeane all ready, I've added all the comments |
nealrichardson
requested changes
Feb 25, 2021
nealrichardson
left a comment
nealrichardson
left a comment
Member
There was a problem hiding this comment.
One last change but otherwise looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.