ARROW-11778: [Rust] Cast from LargeUtf8 to Numerical and temporal types#9571
Closed
ritchie46 wants to merge 5 commits into
Closed
ARROW-11778: [Rust] Cast from LargeUtf8 to Numerical and temporal types#9571ritchie46 wants to merge 5 commits into
ritchie46 wants to merge 5 commits into
Conversation
ritchie46
force-pushed
the
large_utf8_to_numerical
branch
from
ad24ce3 to
cda7de3
Compare
Contributor
|
@ritchie46 you have unused imports somewhere |
Contributor
|
I'll fix the clippy lints, and merge this after #9425 |
Contributor
Author
|
@nevi-me thanks. Sorry about the lints, I totally forgot them today. |
nevi-me
force-pushed
the
large_utf8_to_numerical
branch
from
3ca7ead to
312c082
Compare
Contributor
|
The integration test failure seems like it is unrelated to the changes in this PR: https://issues.apache.org/jira/browse/ARROW-11717 |
alamb
reviewed
Feb 26, 2021
|
|
||
| #[test] | ||
| fn test_cast_string_to_timestamp() { | ||
| let a = StringArray::from(vec
Contributor
There was a problem hiding this comment.
I recommend adding coverage here to convert from LargeUtf8 string arrays as well - I don't think they are covered by these tests
Contributor
Author
There was a problem hiding this comment.
@nevi-me I just fixed this test. I already modified the test with that intention but I apparently tested stringarray twice instead of stringarray and largestringarray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry that the PR's are not more clustered, but they occur to me in the wild.
This PR allows casting from LargeUtf8 to numerical and temporal types. It also modifies the already existing string to temporal casts such that it uses the new faster
from_trusted_lengthiterator API.