Skip to content

[AVRO-2579]: Fix test by sorting fields for deterministic order - #667

Merged
dkulp merged 1 commit into
apache:masterfrom
contextshuffling:sorting-fields
May 26, 2020
Merged

[AVRO-2579]: Fix test by sorting fields for deterministic order#667
dkulp merged 1 commit into
apache:masterfrom
contextshuffling:sorting-fields

Conversation

@contextshuffling

Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • modifies the unit tests to make it more stable

Commits

  • My commits all reference Jira issues in their subject lines

@probot-autolabeler probot-autolabeler Bot added the Java Pull Requests for Java binding label Oct 6, 2019
@contextshuffling contextshuffling changed the title [AVRO-2579]: Fix tests by sorting fields for deterministic order [AVRO-2579]: Fix test by sorting fields for deterministic order Oct 6, 2019
Comment thread lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java Outdated
@contextshuffling

Copy link
Copy Markdown
Contributor Author

CI failed for weird reason. The test passes locally

@Fokko

Fokko commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @contextshuffling

I've restarted the CI, sometimes Travis has some intermittent issues.

@contextshuffling

Copy link
Copy Markdown
Contributor Author

@Fokko any follow-ups on this PR?

@Fokko

Fokko commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

Looks like that Travis had some network issues, I've restarted the CI (again).

@contextshuffling

Copy link
Copy Markdown
Contributor Author

Potentially related: apache/pulsar#6247

@Fokko

Fokko commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @contextshuffling. Can you rebase against latest master?

@contextshuffling

Copy link
Copy Markdown
Contributor Author

@Fokko Sorry for the late reply. should be good now

@Fokko

Fokko commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

We got a failing master again. Normally this doesn't happen that often, but I guess you are very unlucky @contextshuffling I'll check if I can fix master, let me get back to you.

@contextshuffling

Copy link
Copy Markdown
Contributor Author

@Fokko I saw in the log that ImportError: cannot import name 'ContextManager'. First of all, this is in python which I do not see how my changes would touch it. After some search, this looks to be something newly added after py3.6. Is the CI image out-of-dated? Above it, the project itself builds and run all the test successfully and then the CI crashed due to this python script.

@Fokko

Fokko commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@contextshuffling sorry for the late reply. Can you rebase onto master? Current master is green again.

@dkulp
dkulp merged commit a6a0346 into apache:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants