Skip to content

Update instructions to run linter.#416

Closed
tvalentyn wants to merge 1 commit into
apache:asf-sitefrom
tvalentyn:patch-2
Closed

Update instructions to run linter.#416
tvalentyn wants to merge 1 commit into
apache:asf-sitefrom
tvalentyn:patch-2

Conversation

@tvalentyn

Copy link
Copy Markdown

Changes to tox.ini were done in apache/beam#4877.

Changes to tox.ini were done in apache/beam#4877.
@tvalentyn

Copy link
Copy Markdown
Author

R: @udim

@melap

melap commented Apr 10, 2018

Copy link
Copy Markdown

#411 and #415 both also make this change, and the changed line is removed in #414
what is the long term strategy here? from the comments in #411 it sounded like this change will be obsoleted by #414 so #411 was closed

@melap

melap commented Apr 10, 2018

Copy link
Copy Markdown

sorry, removed in #412 (not 415)

@tvalentyn

Copy link
Copy Markdown
Author

Thanks, looks like with #412 this change is no longer needed.

@tvalentyn

Copy link
Copy Markdown
Author

On the other hand since 3 different people were wasting cycles on this during last week, we might as well fix it while #412 is crystalizing, assuming it as simple as running asfgit merge or something similar.

@melap

melap commented Apr 11, 2018

Copy link
Copy Markdown

A fair point, I will merge this

@melap

melap commented Apr 11, 2018

Copy link
Copy Markdown

@asfgit merge

@asfgit asfgit closed this in 280ffad Apr 11, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants