[BEAM-8932][Cleanup] Fix metric reader to use an actually accessible Nonnull annotation.#10807
Closed
dpcollins-google wants to merge 4 commits intoapache:masterfrom
Closed
[BEAM-8932][Cleanup] Fix metric reader to use an actually accessible Nonnull annotation.#10807dpcollins-google wants to merge 4 commits intoapache:masterfrom
dpcollins-google wants to merge 4 commits intoapache:masterfrom
Conversation
added 4 commits
December 28, 2019 03:10
This should have no user-visible effects.
…tack.internal.NotNull RELNOTES:
Contributor
Author
|
+R: @chamikaramj |
Closed
4 tasks
dpcollins-google
force-pushed
the
fix_metric_reader
branch
3 times, most recently
from
9a1c497 to
2054867
Compare
dpcollins-google
changed the title
dpcollins-google
force-pushed
the
fix_metric_reader
branch
from
2054867 to
62e1c4b
Compare
dpcollins-google
force-pushed
the
fix_metric_reader
branch
from
62e1c4b to
ce7680f
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diffbased on #10480
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.