Skip to content

[BEAM-10465] Add checksum for Python source distribution and wheels#12233

Merged
aaltay merged 1 commit intoapache:masterfrom
TobKed:BEAM-10465-checksum-py-source-dist-wheels
Jul 14, 2020
Merged

[BEAM-10465] Add checksum for Python source distribution and wheels#12233
aaltay merged 1 commit intoapache:masterfrom
TobKed:BEAM-10465-checksum-py-source-dist-wheels

Conversation

@TobKed
Copy link
Copy Markdown
Contributor

@TobKed TobKed commented Jul 13, 2020

Add sha512sum for later verification.

test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang --- --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Jul 13, 2020

R: @tvalentyn @aaltay @mwalenia @damgad

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 13, 2020

Do we expect workflows to run when there is a change to workflows?

@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Jul 14, 2020

I am not sure did I understand your question @aaltay .
Updated workflow will run after merging it to the master.
Since workflows are run only when they merged to master it is not possible to verify them before merging. I think a good practice is to put the link to the example run executed on the fork.

Here is the test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 14, 2020

I am not sure did I understand your question @aaltay .
Updated workflow will run after merging it to the master.
Since workflows are run only when they merged to master it is not possible to verify them before merging. I think a good practice is to put the link to the example run executed on the fork.

Here is the test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085

OK. This kind of answers my question. I was asking because:

  • we are able to run workflows on PRs
  • And changing the workflow code should be tested by running the workflow code.

And based on the other PR, it seems like not everyone will be able to run the workflow on their repo. (e.g. they might be missing GCS parts.)

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 14, 2020

I will merge this, I do not want to block the PR. Please respond to my question when you get a chance.

@aaltay aaltay merged commit c946886 into apache:master Jul 14, 2020
@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Jul 15, 2020

@aaltay thanks for merging :)

Actually I was wrong with statement: "workflows are run only when they merged to master".
It is possible to run workflows not merged to master e.g. in PR which introduces new workflow and it is triggered on 'push' event type this new workflow will run.

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

It is possible to include '.github/workflows/**' in paths:
https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L30
Then any change in this dir in PR will trigger Build python wheels workflow run.
Do you think I should create PR with this change?

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 15, 2020

@aaltay thanks for merging :)

Actually I was wrong with statement: "workflows are run only when they merged to master".
It is possible to run workflows not merged to master e.g. in PR which introduces new workflow and it is triggered on 'push' event type this new workflow will run.

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

It is possible to include '.github/workflows/**' in paths:
https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L30
Then any change in this dir in PR will trigger Build python wheels workflow run.
Do you think I should create PR with this change?

Yes, I think it would be good to create that PR and test workflows when the workflow files change.

@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Jul 29, 2020

Sorry for late response. I created PR with basic documentation for GItHub Actions CI #12405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants