Skip to content

[BEAM-10618] subprocess_server.py: Fallback to AF_INET6 family when finding free port #12438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheNeuralBit merged 2 commits into from
Aug 4, 2020
Merged

[BEAM-10618] subprocess_server.py: Fallback to AF_INET6 family when finding free port #12438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
713efed
Use IPv6 socket when finding free port
TheNeuralBit Jul 31, 2020
5a7bdd9
Only use AF_INET6 as a fallback
TheNeuralBit Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions sdks/python/apache_beam/utils/subprocess_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,20 @@ def find_free_port(port):
if port:
return port
else:
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
try:
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
except OSError as e:
# [Errno 97] Address family not supported by protocol
# Likely indicates we are in an IPv6-only environment (BEAM-10618). Try
# again with AF_INET6.
if e.errno == 97:
s = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
else:
raise e

sockets.append(s)
s.bind(('localhost', 0))
_, free_port = s.getsockname()
return free_port
return s.getsockname()[1]

ports = list(map(find_free_port, ports))
# Close sockets only now to avoid the same port to be chosen twice
Expand Down