Skip to content

[BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName #12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boyuanzz merged 1 commit into from
Aug 11, 2020
Merged

[BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName #12518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaSourceDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import javax.annotation.Nullable;
import org.apache.beam.sdk.schemas.AutoValueSchema;
import org.apache.beam.sdk.schemas.annotations.DefaultSchema;
import org.apache.beam.sdk.schemas.annotations.SchemaCreate;
import org.apache.beam.sdk.schemas.annotations.SchemaFieldName;
import org.apache.beam.sdk.schemas.annotations.SchemaIgnore;
import org.apache.kafka.common.TopicPartition;
Expand Down Expand Up @@ -72,4 +73,17 @@ public static KafkaSourceDescriptor of(
startReadTime,
bootstrapServers);
}

@SchemaCreate
@SuppressWarnings("all")
// TODO(BEAM-10677): Remove this function after AutoValueSchema is fixed.
static KafkaSourceDescriptor create(
String topic,
Integer partition,
Long start_read_offset,
Instant start_read_time,
List<String> bootstrap_servers) {
return new AutoValue_KafkaSourceDescriptor(
topic, partition, start_read_offset, start_read_time, bootstrap_servers);
}
}