Skip to content

Better error on BQ schema parse #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 3 commits into from
Aug 14, 2020
Merged

Better error on BQ schema parse #12549

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98076e4
Better error on BQ schema parse
pabloem Aug 12, 2020
ba838f7
Better error on BQ schema parse
pabloem Aug 12, 2020
9c6be10
Fixup
pabloem Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion sdks/python/apache_beam/io/gcp/bigquery_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@
except ImportError:
pass

try:
# TODO(pabloem): Remove this workaround after Python 2.7 support ends.
from json.decoder import JSONDecodeError
except ImportError:
JSONDecodeError = ValueError

# pylint: enable=wrong-import-order, wrong-import-position

_LOGGER = logging.getLogger(__name__)
Expand Down Expand Up @@ -134,7 +140,11 @@ def parse_table_schema_from_json(schema_string):
Returns:
A TableSchema of the BigQuery export from either the Query or the Table.
"""
json_schema = json.loads(schema_string)
try:
json_schema = json.loads(schema_string)
except JSONDecodeError as e:
raise ValueError(
'Unable to parse JSON schema: %s - %r' % (schema_string, e))

def _parse_schema_field(field):
"""Parse a single schema field from dictionary.
Expand Down