[BEAM-7705] Update BigQuery docs with new code snippets#12559
Merged
chamikaramj merged 1 commit intoapache:masterfrom Sep 1, 2020
Merged
[BEAM-7705] Update BigQuery docs with new code snippets#12559chamikaramj merged 1 commit intoapache:masterfrom
chamikaramj merged 1 commit intoapache:masterfrom
Conversation
rosetn
approved these changes
Aug 13, 2020
Contributor
rosetn
left a comment
rosetn
left a comment
There was a problem hiding this comment.
Yes! Thank you for working on these updates! 🙏
LGTM
|
@chamikaramj Do you have a moment to take a look at these? Thank you! :) |
chamikaramj
reviewed
Sep 1, 2020
|
|
||
| {{< highlight java >}} | ||
| {{< code_sample "examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java" BigQueryDataTypes >}} | ||
| {{< code_sample "examples/java/src/main/java/org/apache/beam/examples/snippets/transforms/io/gcp/bigquery/BigQueryTableRowCreate.java" bigquery_table_row_create >}} |
Contributor
There was a problem hiding this comment.
Did you intend to use underscore separated text (not camel case) for Java ?
Author
There was a problem hiding this comment.
We usually do region tags in snake_case for all languages regardless of the language style. The reason is that by keeping them consistent through all languages, it's easier to build tools to parse them and compare between which snippets exist for each language.
chamikaramj
approved these changes
Sep 1, 2020
Contributor
chamikaramj
left a comment
chamikaramj
left a comment
There was a problem hiding this comment.
LGTM other than one comment. Thanks.
Author
|
@aaltay all tests are passing and we have an approval. Is this ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the BigQuery docs to use the new code snippets from #12118
R: @rosetn
R: @aaltay
Staged: http://apache-beam-website-pull-requests.storage.googleapis.com/12559/documentation/io/built-in/google-bigquery/index.html
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.