Skip to content

fix logic issue in metric name namespace filtering #12570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 2 commits into from
Aug 13, 2020
Merged

fix logic issue in metric name namespace filtering #12570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ae855
fix logic issue in metric name namespace filtering
leiyiz Aug 13, 2020
41e4505
refactor boolean logic to be more concise
leiyiz Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions sdks/python/apache_beam/metrics/metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,12 @@ class MetricResults(object):

@staticmethod
def _matches_name(filter, metric_key):
if not filter.names and not filter.namespaces:
return True

if ((filter.namespaces and metric_key.metric.namespace in filter.namespaces)
or (filter.names and metric_key.metric.name in filter.names)):
if ((filter.namespaces and
metric_key.metric.namespace not in filter.namespaces) or
(filter.names and metric_key.metric.name not in filter.names)):
return False
else:
return True
return False

@staticmethod
def _is_sub_list(needle, haystack):
Expand Down