[BEAM-10670] Support impulse within non-portable Spark implementations.#13018
Closed
lukecwik wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-10670] Support impulse within non-portable Spark implementations.#13018lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @iemejia |
4 tasks
Member
Author
|
Run Spark ValidatesRunner |
Member
|
Run Spark StructuredStreaming ValidatesRunner |
Member
Author
Note that spark structured streaming hasn't passed for ~26 days: https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/ When run locally I saw the same failures with |
iemejia
approved these changes
Oct 6, 2020
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM The errors on Structured Streaming runner are unrelated and tracked in BEAM-11023
iemejia
reviewed
Oct 6, 2020
|
|
||
| @Override | ||
| public String toNativeString() { | ||
| return "sparkContext.<impulse>()"; |
Member
There was a problem hiding this comment.
s/sparkContext/streamingContext just for convention. I applied this change on merge.
Member
|
Closing since already merged manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.