[BEAM-11460] Support reading Parquet files with unknown schema#13616
Merged
iemejia merged 9 commits intoapache:masterfrom Dec 25, 2020
anantdamle:read_genericrecord_parquetio
Merged
[BEAM-11460] Support reading Parquet files with unknown schema#13616iemejia merged 9 commits intoapache:masterfrom anantdamle:read_genericrecord_parquetio
iemejia merged 9 commits intoapache:masterfrom
anantdamle:read_genericrecord_parquetio
Conversation
…arseFiles<T>` implementation for supporting files with unknown schema.
1. Fix Javadoc example by using consistent words 1. Other indentation and space fixes
4 tasks
Merge BEAM 2.27.0 into anantdamle fork
Contributor
Author
|
@aromanenko-dev @iemejia have made all the requested changes. Kindly review. |
iemejia
approved these changes
Dec 25, 2020
Member
iemejia
left a comment
There was a problem hiding this comment.
LGTM Thanks @anantdamle !
If you feel motivated to do one easy contribution, documenting and enabling ParquetIO to use Beam schemas (as AvroIO does) could be interesting. Feel free to take this issue if you feel motivated
https://issues.apache.org/jira/browse/BEAM-11526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data engineers encounter times when schema of Parquet file is unknown at the time of writing the pipeline or multiple schema may be present in different files. Reading Parquet files using ParquetIO requires providing an Avro (equivalent) schema, Many a times its not possible to know the schema of the Parquet files.
On the other hand AvroIO supports reading unknow schema files by providing a parse function :
#parseGenericRecords(SerializableFunction<GenericRecord,T>)Supporting this functionality in ParquetIO is simple and requires minimal changes to the ParquetIO surface.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
ParquetIOTestCHANGES.mdwith noteworthy changes.created instead of PR/13554 due to change in source branch.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.