Skip to content

[BEAM-11731][BEAM-10582] Allow pyarrow<4,numpy<1.21.0, improve pyarrow verification#13892

Merged
aaltay merged 5 commits intoapache:masterfrom
TheNeuralBit:BEAM-11731-fix
Feb 6, 2021
Merged

[BEAM-11731][BEAM-10582] Allow pyarrow<4,numpy<1.21.0, improve pyarrow verification#13892
aaltay merged 5 commits intoapache:masterfrom
TheNeuralBit:BEAM-11731-fix

Conversation

@TheNeuralBit
Copy link
Copy Markdown
Member

@TheNeuralBit TheNeuralBit commented Feb 3, 2021

A few simultaneous changes here:

  • Allow pyarrow up to 3.x, numpy up to 1.21.x
  • Modifies CI to use numpy <1.20.0 when testing pyarrow <3 to workaround ARROW-11450
  • Adds a new uses_pyarrow mark, so that we can test both parquetio_test and dataframe.io_test against multiple pyarrow versions

Note this does not protect our users from using numpy 1.20.0 and pyarrow <3. Unfortunately it doesn't look like there's a way to achieve that in setup.py.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2021

Codecov Report

Merging #13892 (204c553) into master (489ab66) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13892      +/-   ##
==========================================
- Coverage   82.86%   82.85%   -0.02%     
==========================================
  Files         466      466              
  Lines       57612    57596      -16     
==========================================
- Hits        47742    47719      -23     
- Misses       9870     9877       +7     
Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/schemas.py 95.31% <100.00%> (ø)
sdks/python/apache_beam/internal/metrics/metric.py 86.45% <0.00%> (-1.05%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.28% <0.00%> (-0.75%) ⬇️
...ache_beam/runners/dataflow/ptransform_overrides.py 90.36% <0.00%> (-0.70%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 73.13% <0.00%> (-0.35%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 75.07% <0.00%> (-0.04%) ⬇️
setup.py 0.00% <0.00%> (ø)
...apache_beam/portability/api/beam_runner_api_pb2.py 100.00% <0.00%> (ø)
...apache_beam/runners/portability/portable_runner.py 76.30% <0.00%> (ø)
...e_beam/portability/api/beam_runner_api_pb2_urns.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56b61a...204c553. Read the comment docs.

@TheNeuralBit
Copy link
Copy Markdown
Member Author

Run Python PreCommit

@TheNeuralBit TheNeuralBit requested a review from aaltay February 5, 2021 23:00
@aaltay
Copy link
Copy Markdown
Member

aaltay commented Feb 6, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants