[BEAM-11731][BEAM-10582] Allow pyarrow<4,numpy<1.21.0, improve pyarrow verification#13892
Merged
aaltay merged 5 commits intoapache:masterfrom Feb 6, 2021
Merged
[BEAM-11731][BEAM-10582] Allow pyarrow<4,numpy<1.21.0, improve pyarrow verification#13892aaltay merged 5 commits intoapache:masterfrom
aaltay merged 5 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13892 +/- ##
==========================================
- Coverage 82.86% 82.85% -0.02%
==========================================
Files 466 466
Lines 57612 57596 -16
==========================================
- Hits 47742 47719 -23
- Misses 9870 9877 +7
Continue to review full report at Codecov.
|
Member
Author
|
Run Python PreCommit |
aaltay
approved these changes
Feb 6, 2021
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few simultaneous changes here:
uses_pyarrowmark, so that we can test bothparquetio_testanddataframe.io_testagainst multiple pyarrow versionsNote this does not protect our users from using numpy 1.20.0 and pyarrow <3. Unfortunately it doesn't look like there's a way to achieve that in setup.py.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.