[BEAM-11712] Run TPC-DS via BeamSQL and Spark runner#14373
[BEAM-11712] Run TPC-DS via BeamSQL and Spark runner#14373aromanenko-dev wants to merge 2 commits intoapache:masterfrom
Conversation
aromanenko-dev
force-pushed
the
BEAM-11712-TPCDS-Spark
branch
5 times, most recently
from
0333d5d to
2cebe19
Compare
|
retest this please |
|
The Workflow run is cancelling this PR. It is an earlier duplicate of 2173354 run. |
|
Run Java PreCommit |
aromanenko-dev
force-pushed
the
BEAM-11712-TPCDS-Spark
branch
from
2cebe19 to
11c28ba
Compare
aromanenko-dev
force-pushed
the
BEAM-11712-TPCDS-Spark
branch
from
11c28ba to
a1f1f22
Compare
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM. I will merge manually to fix some typos and minor IntelliJ analysis warnings.
Can you please in a subsequent PR remove the README and better add this info into the website in a new webpage probably in the same section than Nexmark is, or into the wiki.
|
Merged now, thanks @aromanenko-dev |
Yes, it was a plan to do this later. Thanks! |
| } | ||
| plugins { id 'org.apache.beam.module' } | ||
| applyJavaNature( | ||
| automaticModuleName: 'org.apache.beam.sdk.tpcds', |
There was a problem hiding this comment.
Do we want to publish this package during beam release?
| def isDataflowRunner = ":runners:google-cloud-dataflow-java".equals(tpcdsRunnerDependency) | ||
| def runnerConfiguration = ":runners:direct-java".equals(tpcdsRunnerDependency) ? "shadow" : null | ||
|
|
||
| if (isDataflowRunner) { |
There was a problem hiding this comment.
@kennknowles I'm not sure about the purpose of this test but do we consider adding runner_v2 as well?
There was a problem hiding this comment.
It is a standard benchmark suite. Yes, it makes sense to run on runner_v2 (and any other runner configuration someone is interested in)
4 participants
build.gradleto "standard" project way and make it possible to run via SparkRunnerR: @iemejia
CC R: @kennknowles
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.