[BEAM-13996] Removing 'No cluster_manager is associated with the provided pipeline!' logger error#16936
Merged
nika-qubit merged 1 commit intoapache:masterfrom Feb 24, 2022
Conversation
…ided pipeline!' logger error
victorplusc
force-pushed
the
removing_no_cluster_manager_logger_error
branch
from
87f3117 to
c44b4f9
Compare
4 tasks
Contributor
Author
|
R: @kevingg |
Codecov Report
@@ Coverage Diff @@
## master #16936 +/- ##
===========================================
+ Coverage 46.89% 83.62% +36.73%
===========================================
Files 204 453 +249
Lines 20122 62478 +42356
===========================================
+ Hits 9436 52247 +42811
- Misses 9686 10231 +545
+ Partials 1000 0 -1000
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rohdesamuel
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: removing the 'No cluster_manager is associated with the provided pipeline!' logger error message when a pipeline is present, but has no cluster manager. The bug in this scenario is that this case can be triggered when the user uses Interactive Beam in a way that automatically cleans up an individual pipeline (e.g. running InteractiveRunner() using a
withclause).Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.