[BEAM-12815] Try to fix flaky Flink Post Commit#17227
Merged
lostluck merged 7 commits intoapache:masterfrom Mar 31, 2022
Merged
[BEAM-12815] Try to fix flaky Flink Post Commit#17227lostluck merged 7 commits intoapache:masterfrom
lostluck merged 7 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Contributor
Author
|
Run XVR_Flink PostCommit |
Contributor
Author
|
Run XVR_Flink PostCommit |
Contributor
Author
|
Run Go Flink ValidatesRunner |
Contributor
Author
|
Run Go Flink ValidatesRunner |
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lostluck
approved these changes
Mar 31, 2022
Contributor
lostluck
left a comment
There was a problem hiding this comment.
Sounds good. Ping me if a revert is needed. Thanks!
Contributor
Author
|
Run XVR_Flink PostCommit |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, Go flink Post commits are failing with
java.io.IOException: Insufficient number of network buffers: required 17, but only 16 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'.This is the same underlying issue I fixed in #17067 but it shows up again here because we have a different mechanism for spinning up flink for these post commit tests. This PR does 2 things:
beam/runners/flink/job-server/flink_job_server.gradle
Line 116 in 5a62228
NOTE: The post commit changes (changing PflinkConfDir) aren't able to be tested because I can't actually repro the problem locally, and Jenkin's infra seems to run post commits against master (even when triggered against PRs). So this may not work, but the blast radius (potential to briefly break post-commits) is relatively small, and I'll quickly revert it if this makes things any worse. I do feel pretty confident it won't make things worse though since I was able to at least run the tests locally with
-PflinkConfDir=$pwd/runners/flink/src/test/resources.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.