Skip to content

[BEAM-13657] Sunset python 3.6#17252

Merged
tvalentyn merged 10 commits intoapache:masterfrom
AnandInguva:sunset-python36
Apr 21, 2022
Merged

[BEAM-13657] Sunset python 3.6#17252
tvalentyn merged 10 commits intoapache:masterfrom
AnandInguva:sunset-python36

Conversation

@AnandInguva
Copy link
Copy Markdown
Contributor

@AnandInguva AnandInguva commented Apr 1, 2022

Python 3.6 has reached EOL. Sunset Python3.6 support from Apache Beam


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link
Copy Markdown

asf-ci commented Apr 1, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link
Copy Markdown

asf-ci commented Apr 1, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link
Copy Markdown

asf-ci commented Apr 1, 2022

Can one of the admins verify this patch?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2022

Codecov Report

Merging #17252 (1c6eddb) into master (8a71bcb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17252      +/-   ##
==========================================
- Coverage   74.12%   74.11%   -0.02%     
==========================================
  Files         677      681       +4     
  Lines       89069    89229     +160     
==========================================
+ Hits        66021    66130     +109     
- Misses      21897    21948      +51     
  Partials     1151     1151              
Flag Coverage Δ
python 83.64% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/parquetio.py 95.16% <0.00%> (-0.98%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 81.09% <0.00%> (-0.73%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
.../apache_beam/io/gcp/datastore/v1new/datastoreio.py 86.16% <0.00%> (-0.29%) ⬇️
...he_beam/runners/interactive/sql/beam_sql_magics.py 49.51% <0.00%> (-0.24%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (-0.17%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
...am/runners/interactive/options/capture_limiters.py 90.76% <0.00%> (-0.14%) ⬇️
sdks/python/apache_beam/transforms/external.py 79.89% <0.00%> (-0.11%) ⬇️
.../runners/interactive/testing/test_cache_manager.py 92.75% <0.00%> (-0.11%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a71bcb...1c6eddb. Read the comment docs.

@github-actions github-actions bot added the infra label Apr 1, 2022
@AnandInguva
Copy link
Copy Markdown
Contributor Author

Run Seed Job

@AnandInguva
Copy link
Copy Markdown
Contributor Author

Run Portable_Python PreCommit

@TheNeuralBit TheNeuralBit changed the title [BEAM-13657]Sunset python36 [BEAM-13657] Sunset python 3.6 Apr 6, 2022
Copy link
Copy Markdown
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnandInguva this looks good. Before we run the seed job (and drop the Python 3.6 PostCommits), can you send a message to dev@ to let people know there won't be any verification of Py 3.6?

@TheNeuralBit
Copy link
Copy Markdown
Member

Please also resolve the conflict in tox.ini

Copy link
Copy Markdown

@bschoening bschoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TheNeuralBit
Copy link
Copy Markdown
Member

Run Portable_Python PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

Run SQL PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

Run SQL_Java17 PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

Run Seed Job

1 similar comment
@TheNeuralBit
Copy link
Copy Markdown
Member

Run Seed Job

@TheNeuralBit
Copy link
Copy Markdown
Member

Run CommunityMetrics PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

TheNeuralBit commented Apr 6, 2022

Turns out you can't run seed job if the author of the PR is not a committer. I cloned your PR in #17307 to run the seed job there.

https://ci-beam.apache.org/job/beam_SeedJob/9484/

@ibzib
Copy link
Copy Markdown

ibzib commented Apr 6, 2022

ok to test

@ibzib
Copy link
Copy Markdown

ibzib commented Apr 6, 2022

run seed job

@TheNeuralBit
Copy link
Copy Markdown
Member

Run Portable_Python PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

CommunityMetrics is perma-red: BEAM-14017

@TheNeuralBit
Copy link
Copy Markdown
Member

Run GoPortable PreCommit

@TheNeuralBit
Copy link
Copy Markdown
Member

Run Python PreCommit

@AnandInguva
Copy link
Copy Markdown
Contributor Author

cc: @emilymye

@tvalentyn tvalentyn merged commit 378338c into apache:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants