[Spark runner] Removal of Spark 2 runner support#25263
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #25263 +/- ##
=======================================
Coverage 72.95% 72.95%
=======================================
Files 745 745
Lines 99191 99191
=======================================
+ Hits 72361 72369 +8
+ Misses 25465 25456 -9
- Partials 1365 1366 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2ef241c to
1e76728
Compare
|
R: @je-ik |
|
Run Python_Runners PreCommit |
1 similar comment
|
Run Python_Runners PreCommit |
|
Run Java_Pulsar_IO_Direct PreCommit |
|
@aromanenko-dev Could you have a look, pls. Any objections moving ahead with the removal? |
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks, LGTM, just several minor questions, ptal
Before merging, please, run all related pre- and post- commit jobs to make sure that nothing is broken.
|
Run Python Spark ValidatesRunner |
|
Run Java PostCommit |
|
Run SQL PostCommit |
|
Run Go PostCommit |
@aromanenko-dev This pretty much triggered all |
|
@mosche Nope, I think it should be enough |
|
@mosche Could you rebase a feature branch against |
|
@aromanenko-dev That's what github does if resolving a conflict in the UI. It absolutely doesn't make a difference if squashed before merging. |
|
Run Java_Kafka_IO_Direct PreCommit |
The runner for Spark 2 was deprecated quite a while back in August 2022 with the release of Beam 2.41.0.
This PR finally removes support for Spark 2 (beam-runners-spark) to only maintain support for Spark 3 (beam-runners-spark-3) going forward.
Closes #25259
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.