Conversation
Contributor
Author
|
R: @damccorm |
Codecov Report
@@ Coverage Diff @@
## master #25545 +/- ##
==========================================
- Coverage 72.80% 72.66% -0.15%
==========================================
Files 750 758 +8
Lines 99314 100681 +1367
==========================================
+ Hits 72304 73155 +851
- Misses 25648 26118 +470
- Partials 1362 1408 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
damccorm
approved these changes
Feb 17, 2023
Contributor
Author
|
Given the breadth of effect, I'm going to wait for the various test runs to complete first. |
Contributor
Author
|
The last change everything but the go tests passed, and the last change only affected the Go tests. This should be safe to merge, but I'll keep an eye on the postcommit runs just in case, so we can roll it back promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New dependencies have required the Go SDK minimum Go version to be increased to 1.19 at minimum, which is the current trailing stable Go version.
Users are likely already on 1.20 by now, so this largely affects Beam infra, which has also been updated in this PR.
Motivated by coverage failing when run under Go 1.18: https://github.com/apache/beam/actions/runs/4207200414/jobs/7301693353
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.