Enable FirestoreV1IT to run against a non default host#27256
Enable FirestoreV1IT to run against a non default host#27256Abacn merged 8 commits intoapache:masterfrom SabaSathya:ss-firestore-host
Conversation
|
addresses #27255 |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run PostCommit_Java_Dataflow |
|
Run PostCommit_Java_DataflowV2 |
|
Hi, I disabled FirestoreV1IT again on master due to test failures: #27267 I see the same test failure on this PR: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/182/ For testing this PR now it would need to remove the exclusion here: |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
R: @pcostell for Firestore. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
...rm/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java
Outdated
Show resolved
Hide resolved
…) other than default endpoint for testing purposes. If FIRESTORE_HOST env variable is set, it will be used as Firestore endpoint. If FIRESTORE_HOST env variable is not set, the default endpoint will be used.
|
What are next steps on this PR? @SabaSathya @pcostell @Abacn |
|
FirestoreV1IT integration tests need to be triggered by phrase To confirm, is this PR still blocked by #25851 ? |
...rm/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java
Outdated
Show resolved
Hide resolved
...le-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/it/BaseFirestoreIT.java
Outdated
Show resolved
Hide resolved
...ogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreOptions.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreStatefulComponentFactory.java
Outdated
Show resolved
Hide resolved
...d-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/it/FirestoreTestingHelper.java
Show resolved
Hide resolved
|
This PR results in a command line arg of cc @Abacn |
Thanks, this sounds totally reasonable and I should have noticed this honestly. Would you mind drafting a PR for it. This flag currently is used for testing purpose so it should be fine |
Added setHost() and getHost() to FirestoreOptions to allow endpoint (i.e. host + port) other than default endpoint for testing purposes.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.