Skip to content

Disable FirestoreIT tests on Dataflow #27267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Jun 27, 2023
Merged

Disable FirestoreIT tests on Dataflow #27267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767951e
Disable FirestoreIT tests on Dataflow
Abacn Jun 27, 2023
b85d7a6
Fix spotless
Abacn Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions runners/google-cloud-dataflow-java/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,8 @@ task googleCloudPlatformLegacyWorkerIntegrationTest(type: Test, dependsOn: copyG
exclude '**/PubsubReadIT.class'
exclude '**/FhirIOReadIT.class'
exclude '**/gcp/spanner/changestreams/it/*.class'
// TODO(https://github.com/apache/beam/issues/25851) failing due to internal Firestore breaking change
exclude '**/FirestoreV1IT.class'
maxParallelForks 4
classpath = configurations.googleCloudPlatformIntegrationTest
testClassesDirs = files(project(":sdks:java:io:google-cloud-platform").sourceSets.test.output.classesDirs)
Expand Down Expand Up @@ -606,6 +608,8 @@ task googleCloudPlatformRunnerV2IntegrationTest(type: Test) {
exclude '**/FhirIOLROIT.class'
exclude '**/FhirIOSearchIT.class'
exclude '**/FhirIOPatientEverythingIT.class'
// TODO(https://github.com/apache/beam/issues/25851) failing due to internal Firestore breaking change
exclude '**/FirestoreV1IT.class'

maxParallelForks 4
classpath = configurations.googleCloudPlatformIntegrationTest
Expand Down
3 changes: 0 additions & 3 deletions ...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/it/BaseFirestoreIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.util.concurrent.MoreExecutors;
import org.joda.time.Instant;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
Expand Down Expand Up @@ -186,8 +185,6 @@ public final void listCollections() throws Exception {
}

@Test
@Ignore(
"https://github.com/apache/beam/issues/25851 failing due to internal Firestore breaking change")
public final void listDocuments() throws Exception {
DocumentGenerator documentGenerator = helper.documentGenerator(NUM_ITEMS_TO_GENERATE, "a");
Instant readTime =
Expand Down