Fetch buffer and add it to pcoll_buffer to avoid element duplication when buffer is None#27676
Merged
AnandInguva merged 3 commits intoapache:masterfrom Jul 27, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27676 +/- ##
==========================================
+ Coverage 70.93% 70.95% +0.02%
==========================================
Files 861 861
Lines 104806 104812 +6
==========================================
+ Hits 74341 74372 +31
+ Misses 28907 28882 -25
Partials 1558 1558
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnandInguva
force-pushed
the
fn_runner_bug
branch
from
422fa67 to
af019ff
Compare
Contributor
Author
|
R: @tvalentyn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
tvalentyn
reviewed
Jul 26, 2023
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
Outdated
Show resolved
Hide resolved
tvalentyn
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt was made at #27373 to solve #25315, #23228 but it resulted in failures in google3.
I missed the step of adding the ListBuffer to pcoll_buffers and buffer_id to buffers_to_clean to clean up the buffers in the later stages. Without this, sometimes the elements in the PColl gets duplicated.
With this PR, I am running a TAP train to see if the tests in google3 passes -. TAP train passes: https://fusion2.corp.google.com/presubmit/551096614/OCL:551096614:BASE:551101442:1690371932534:fe032276/targets
Fixes: #25315
Fixes: #23228
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.