Skip to content

Fix routing header issue in Firestore Beam connector#27858

Merged
damondouglas merged 5 commits intoapache:masterfrom
pl04351820:main
Aug 7, 2023
Merged

Fix routing header issue in Firestore Beam connector#27858
damondouglas merged 5 commits intoapache:masterfrom
pl04351820:main

Conversation

@pl04351820
Copy link
Copy Markdown
Contributor

Fix routing header issue in Firestore Beam connector

The change is tested via

$ ./gradlew integrationTest -p sdks/java/io/google-cloud-platform -PgcpProject={project-id} --tests=org.apache.beam.sdk.io.gcp.firestore.it.FirestoreV1IT  --stacktrace

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 4, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2023

R: @kennknowles for final approval

@damondouglas damondouglas merged commit 23d44a4 into apache:master Aug 7, 2023
@pl04351820 pl04351820 deleted the main branch August 7, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants