Add buffered logger to the Python bootloader#28317
Merged
jrmccluskey merged 3 commits intoapache:masterfrom Sep 7, 2023
Merged
Add buffered logger to the Python bootloader#28317jrmccluskey merged 3 commits intoapache:masterfrom
jrmccluskey merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
CC: @tvalentyn |
Codecov Report
@@ Coverage Diff @@
## master #28317 +/- ##
==========================================
- Coverage 72.34% 72.33% -0.02%
==========================================
Files 680 680
Lines 100280 100323 +43
==========================================
+ Hits 72552 72566 +14
- Misses 26152 26184 +32
+ Partials 1576 1573 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
Run PythonLint PreCommit |
Contributor
Author
tvalentyn
reviewed
Sep 6, 2023
tvalentyn
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the buffered logger type to the Python bootloader script, capturing subprocess output and assigning an appropriate severity to them over the FnAPI (debug if the subprocess returns exit code 0, error if the subprocess returns exit code 1.) Also removes the quiet directive from pip invocations so full output is captured.
Example of new pip output, with package information logged appropriately:

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.