BigQuery: Decouple clustering from time partitioning when writing#30094
Merged
damondouglas merged 7 commits intoapache:masterfrom Jan 30, 2024
Merged
BigQuery: Decouple clustering from time partitioning when writing#30094damondouglas merged 7 commits intoapache:masterfrom
damondouglas merged 7 commits intoapache:masterfrom
Conversation
…am/sdk/io/gcp/bigquery/DynamicDestinationsHelpers.java Co-authored-by: Michel Davit <michel@davit.fr>
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
retest this please |
Contributor
Author
|
Run Java_GCP_IO_Direct PreCommit |
Contributor
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
@damondouglas could you please take a look at this one? |
damondouglas
approved these changes
Jan 30, 2024
Contributor
damondouglas
left a comment
There was a problem hiding this comment.
@GStravinsky Thank you for your contribution! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20673
BigQuery allows to have clustered but not time-partitioned tables. Beam should allow it too.
Used #27097 as a starting point
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.