Skip to content

[Cherry Pick #29979] Fix race condition in Dataflow sampler.#30144

Merged
lostluck merged 2 commits intoapache:release-2.54.0from
lostluck:cp29979
Jan 30, 2024
Merged

[Cherry Pick #29979] Fix race condition in Dataflow sampler.#30144
lostluck merged 2 commits intoapache:release-2.54.0from
lostluck:cp29979

Conversation

@lostluck
Copy link
Copy Markdown
Contributor

Cherry pick of #29979 to fix #29987 in 2.54.0


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@clmccart
Copy link
Copy Markdown
Contributor

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@lostluck
Copy link
Copy Markdown
Contributor Author

I suspect the failing runs are more to do with the release branch and not having the dataflow images built for the release yet, than this specific change. I'll be merging this in once this last rerun finishes.

@lostluck lostluck merged commit 1c974aa into apache:release-2.54.0 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants