Skip to content

Minimize scope of expensive lock #30679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 6 commits into from
Mar 20, 2024
Merged

Minimize scope of expensive lock #30679

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eda0b51
Minimize scope of expensive lock
damccorm Mar 19, 2024
434a333
Build list in lock
damccorm Mar 20, 2024
cccaeee
Update sdks/python/apache_beam/runners/worker/sdk_worker.py
damccorm Mar 20, 2024
b5a45c1
Move comment
damccorm Mar 20, 2024
d927d98
Simplify
damccorm Mar 20, 2024
afe5bc1
fmt
damccorm Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sdks/python/apache_beam/runners/worker/sdk_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,12 +607,18 @@ def _schedule_periodic_shutdown(self):
# type: () -> None
def shutdown_inactive_bundle_processors():
# type: () -> None
inactive_descriptor_ids = []
inactive_time = time.time(
) - DEFAULT_BUNDLE_PROCESSOR_CACHE_SHUTDOWN_THRESHOLD_S
with self._lock:
for descriptor_id, last_access_time in self.last_access_times.items():
if (time.time() - last_access_time >
DEFAULT_BUNDLE_PROCESSOR_CACHE_SHUTDOWN_THRESHOLD_S):
BundleProcessorCache._shutdown_cached_bundle_processors(
self.cached_bundle_processors[descriptor_id])
if (inactive_time > last_access_time):
inactive_descriptor_ids.append(descriptor_id)

# Shutdown can be expensive, keep out of lock
for descriptor_id in inactive_descriptor_ids:
BundleProcessorCache._shutdown_cached_bundle_processors(
self.cached_bundle_processors[descriptor_id])

self.periodic_shutdown = PeriodicThread(
DEFAULT_BUNDLE_PROCESSOR_CACHE_SHUTDOWN_THRESHOLD_S,
Expand Down